Skip to content

fix: CID check in Email class #9645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 28, 2025
Merged

fix: CID check in Email class #9645

merged 2 commits into from
Jul 28, 2025

Conversation

michalsn
Copy link
Member

Description
This PR fixes a bug introduced during recent refactoring, where we assumed that every attachment includes a cid key.

Fixes #9644

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@samsonasik samsonasik merged commit 3aeabec into codeigniter4:develop Jul 28, 2025
50 checks passed
@samsonasik
Copy link
Member

Thank you @michalsn

@michalsn michalsn added the bug Verified issues on the current code behavior or pull requests that will fix them label Jul 29, 2025
@michalsn michalsn deleted the fix/email-cid branch July 30, 2025 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samsonasik samsonasik samsonasik approved these changes

Assignees
No one assigned
Labels
bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Issue with email attachment after upgrading from 4.6.1 to 4.6.2
2 participants
@michalsn @samsonasik